Add support for generating class entries from stubs

[kocsismate]

No description provided.

[ondrejmirtes]

Beautiful! I noticed that some properties have a PHPDoc type and some have a native type. Is there still time to take the major version opportunity to turn more of them to native type (not just in stubs but in the actual implementation)? It’d be beneficial because overriden properties in child classes need to have the same native type (they’re invariant).

[kocsismate]

Is there still time to take the major version opportunity to turn more of them to native type

@ondrejmirtes No, unfortunately, it's way too late to do so, despite how tempting it is.

[ondrejmirtes]

Looking at the milestone - this isn't gonna make PHP 8.0?

[kocsismate]

Looking at the milestone - this isn't gonna make PHP 8.0?

At first, I was also a tiny little bit surprised, but after rethinking, it's a substantial change (especially the code generation part), and we've already after the very last days.

The only reason why it could make sense to still allow this into PHP 8.0 is to avoid merge conflicts due to changes in stub hashes. I'm not sure how often we'll have to fix php 8.0. signatures, but I'd expect a non-negligible amount, since they are very new. personally, I'd also be ok with a compromise, and just add the properties for php 8.0 without code generation, but it's Nikita's and the release managers' call.

[ondrejmirtes]

OK, thanks for the heads up. I just realized I can use the stubs in PHPStan in a little bit different way and essentially just read the parameter names and types and the return types (instead of using them as the full reflection representation), which is how they're meant to be used anyway :)

[ondrejmirtes]

Alright, managed to make it work :) https://twitter.com/OndrejMirtes/status/1314218370682818561

[kocsismate]

@nikic Now that PHP 8.0.0 is done (although methodsynopsis generation is yet to be finished), can you please take a look at this PR again sometime soon? AFAIR the main concern currently is how it works for classes overriding the get_iterator handler. In my last commit, I generated a few such class entries, but I'm not sure if there is any related issue.

[nikic]

@nikic Now that PHP 8.0.0 is done (although methodsynopsis generation is yet to be finished), can you please take a look at this PR again sometime soon? AFAIR the main concern currently is how it works for classes overriding the get_iterator handler. In my last commit, I generated a few such class entries, but I'm not sure if there is any related issue.

I think ultimately, setting get_iterator after doing the implements is okay as well. I think the only negative effect this has is that an unnecessary zend_class_iterator_funcs structure can be created. But apart from that, I think everything will work correctly.

[nikic]

Okay, my first fix for the exception issue wasn't quite right. It caused phpdbg failures on windows. Hopefully this one works.

[nikic]

This generally looks good to me, nice work!

[kocsismate]

Thanks for the review and the fixes! I can take care of the rest later this week :)

[kocsismate]

@nikic Thanks again for the help! I'll start migrating the stubs to use @generate-class-entries in the following days. And I think I can also add support for registering properties which have a union type containing multiple classes a bit later. :)