Fix #80242: imap_mail_compose() segfaults for multipart with rfc822 #6345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libc-client expects TYPEMESSAGE with an explicit subtype of RFC822 to have a nested.msg (otherwise there will be a segfault during free), but not to have any contents.text.data (this will leak otherwise).
|
Is there any different to #6343 here, apart from the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libc-client expects TYPEMESSAGE with an explicit subtype of RFC822 to
have a nested.msg (otherwise there will be a segfault during free), but
not to have any contents.text.data (this will leak otherwise).
Turns out that this is basically the same issue as PR #6343, but that PR is about a regression in 7.3.24RC1 and 7.4.12RC1, while this "never" worked.