Adds tests for uncloneable Error and Exception classes #6388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder why these can't be cloned. I don't see an obvious technical reason. |
|
Well the source says that exceptions and errors should not be cloned, same goes for generators for instance, I guess they're not supposed to be cloned, these tests just ensures this behavior is true |
Girgias
reviewed
Oct 29, 2020
|
Could you rebase this on top of master if this is still relevant? |
|
There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two tests making sure that objects of type Exception and Error are not cloneable