Deprecate passing null to non-nullable arg of internal function #6475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nikic
commented
Dec 1, 2020
iluuu1994
reviewed
Dec 1, 2020
Zend/zend_API.c
Outdated
| @@ -426,9 +426,20 @@ ZEND_API bool ZEND_FASTCALL zend_parse_arg_class(zval *arg, zend_class_entry **p | |||
| } | |||
| /* }}} */ | |||
|
|
|||
| static ZEND_COLD bool zend_null_arg_deprecated(const char *type) { | |||
| zend_string *func_name = get_active_function_or_method_name(); | |||
| zend_error(E_DEPRECATED, "%s(): Passing null to argument of type %s is deprecated", | |||
There was a problem hiding this comment.
Shouldn't it say "Passing null as argument" or "Passing null to parameter"?
There was a problem hiding this comment.
I've changed it to say "Passing null to parameter".
There was a problem hiding this comment.
I decided to thread through the argument number after all, and provide a more detailed error message:
Deprecated: date_interval_create_from_date_string(): Passing null to parameter #1 ($datetime) of type string is deprecated
nikic
force-pushed
the
zpp-null2
branch
7 times, most recently
from
dd4e487 to
545a30b
Compare
|
Yay, all tests passing. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg.
TODO: