opcache, distinguishing segments on stats tools for Mac. #6628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sample output :
|
nikic
reviewed
Jan 25, 2021
ext/opcache/shared_alloc_mmap.c
Outdated
| @@ -87,6 +91,12 @@ static int create_segments(size_t requested_size, zend_shared_segment ***shared_ | |||
| if (p != MAP_FAILED) { | |||
| goto success; | |||
| } | |||
| #elif defined(VM_MAKE_TAG) | |||
| /* allows tracking segments via tools such as vmmap */ | |||
| p = mmap(NULL, requested_size, flags, MAP_SHARED|MAP_ANONYMOUS, VM_MAKE_TAG(251), 0); | |||
There was a problem hiding this comment.
I think it would be better to use something like
int fd = -1;
#if defined(VM_MAKE_TAG)
fd = VM_MAKE_TAG(251)
#endif
and then use fd in the mmap calls. This makes sure this code continues working even if macos supports MAP_32BIT or MAP_HUGETLB in the future.
devnexen
force-pushed
the
opcache_segments_id_on_mac
branch
from
6afbb97 to
86314b8
Compare
nikic
approved these changes
Jan 26, 2021
|
FYI, this does not pass a build with UndefinedBehaviorSanitizer:
My guess is that it should be saved as unsigned, then cast/memcpy'd to signed or something? Edit: it looks like it may be as simple as saying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.