opcache jit for Mac x86 getting tsrm tcb offset cached/ZTS build #6659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposal. Tested with php-cgi and wordpress and 1255 for jit settings.
|
If this works - please commit. |
dstogov
approved these changes
Feb 8, 2021
|
I have reverted this change in f74a02d, as it (presumably) causes many test failures on MacOS ZTS with JIT, see https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=14713&view=ms.vss-test-web.build-test-results-tab. There are a few thousand segfaulting tests for the JIT configurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal.
Tested with php-cgi and wordpress and 1255 for jit settings.