Extend error control operator to suppress exceptions #6757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
error-silence-exception-adding-try-catch-opcodes
branch
from
fdc8a29 to
c1da0b5
Compare
Girgias
force-pushed
the
error-silence-exception-adding-try-catch-opcodes
branch
from
c1da0b5 to
b639017
Compare
Girgias
force-pushed
the
error-silence-exception-adding-try-catch-opcodes
branch
from
b639017 to
e39218f
Compare
|
@Girgias Has this gone stale? Will you continue working on this or can this PR be closed? |
I'm not sure I'll be able to work on this for this release cycle, but it is still in the back of my mind. :) |
|
@Girgias No problem, this can stay open. We're just trying to close anything that has no chance of going anywhere. |
Also fixes a bug where any return value from @<class> would be NULL
This reverts commit 4cc48b35040bf462769f0ad75c521cf1705c2c74.
Girgias
force-pushed
the
error-silence-exception-adding-try-catch-opcodes
branch
from
e39218f to
c45e918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept PR for the "Extend error control operator to suppress exceptions" RFC which can currently be found on GitHub.
Features:
@operator now will also suppress instances ofException(notThrowable) thrown by the expression it prefixes.@<class_union_list>syntax which suppress instances of classes in the union list (can be an instances ofError), without suppressing diagnostics.Issues to fix:
Considerations:
false|nullfor BC considerations.This introduces "virtual" try-catch blocks by inserting CATCH opcodes after the END_SILENCE opcode