Convert IMAPConnection to IMAP\Connection #6925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree! And we can also do the same with FTPConnection and LDAPConnection |
nikic
approved these changes
May 5, 2021
There was a problem hiding this comment.
RFC has been accepted, I mentioned this particular example in https://externals.io/message/114070#114261 and I don't see any usages in https://beta.grep.app/search?q=namespace%20IMAP%5Cs%2A%5B%7B%3B%5D®exp=true, so this should be good to go.
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 6, 2021
Followed by the bundled extension namespace RFC, php#6925 updated the `IMAPConnection` class to `IMAP\Connection`. This updates the UPGRADING file to reflect that change.
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 6, 2021
Followed by the bundled extension namespace RFC, php#6925 updated the `IMAPConnection` class to `IMAP\Connection`. This updates the UPGRADING file to reflect that change.
Girgias
pushed a commit
that referenced
this pull request
May 6, 2021
Followed by the bundled extension namespace RFC, #6925 updated the `IMAPConnection` class to `IMAP\Connection`. This updates the UPGRADING file to reflect that change.
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions] passed, it is possible to rename the new `\FTPConnection` to `\FTP` namespace. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, it is possible to rename the new `\FTPConnection` to `\FTP` namespace. This also adds the entry to `./UPGRADING` file. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, it is possible to rename the new `\FTPConnection` class to `\FTP` namespace. This also adds the entry to `./UPGRADING` file. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`. This also adds an entry to `./UPGRADING` file. Related: php#6925, php#5945
nikic
pushed a commit
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`. This also adds an entry to `./UPGRADING` file. Related: #6925, #5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) RFC. Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
nikic
pushed a commit
that referenced
this pull request
May 9, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: #6925, #5945, #6960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this a newly introduced class in PHP 8.1 and the "Namespaces in bundled PHP extensions" RFC is passing, it makes sense to introduce the IMAP namespace for it.