-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix Zend License header inconsistencies #7166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Mentioned URL does not exist anymore. * Zend cannot be contacted anymore using [email protected]. Given that the Zend LICENSE file is still provided, removing those lines still respect the license.
This looks okay to me in that it does not touch the license itself and just removes outdated information on where to find it. Let's give @zsuraski a ping in case he has concerns. |
The email address ([email protected]) is operational again. I'm looking into the license file to see if we can re-establish that URL as well. |
URL for the license file is now restored (it redirects to a new location, though). As such, this change is no longer necessary - thanks for reaching out on Twitter, @patrickallaert ! |
I have a question. I'm working with the Perforce legal department (Zend is a subsidiary of Perforce) to update the license as follows:
The changes definitely warrant bumping the version. The original plan was to say "2.01", but since it's a change in the copyright owner, "v3.00" has also been proposed. In each case, this may mean updating php-src to reference the new version number, even though, substantively, nothing has changed. My questions:
Thanks in advance! |
@ramsey may want to comment, as we was the liason with OSI when they approved the PHP license 3.01 as proper open source license. |
The OSI approved the PHP License 3.01, which is here: https://www.php.net/license/3_01.txt Changing the years on the copyright won't affect its status with the OSI. This thread is about changes to the Zend Engine License, though, right? This one? https://github.com/php/php-src/blob/master/Zend/LICENSE Since the Zend Engine License isn't technically an OSI-approved license, any changes to it that necessitate a version bump won't affect its status with the OSI. |
@ramsey yes - this is specifically around the Zend Engine license. The original PR was going to remove links to the license on zend.com, as well as to the [email protected] email address, as they were no longer working; I was able to resurrect those, but that raised questions around the license itself that I brought to the attention of the Perforce legal team. That's what my questions above are related to, as they deal with references to the Zend Engine license. |
IANAL, but I don't think the version number needs to change if you're changing the copyright owner. The license has no material changes and still provides the same terms. It would be like if you forked my MIT-licensed project and added your own copyright notice to it. The license didn't change. |
Although, I guess you're changing the actual text of the license itself, since it currently states "Zend Technologies Ltd." as part of the license. So, maybe that does require a version bump. I would probably go with |
Sounds reasonable. Would you also like a PR after we publish it to update the LICENSE file and headers in php-src? |
That sounds good to me. |
Likely be end of week or next week before I can get all this ready, but thanks for the guidance, @ramsey ! |
Updated to: - Reference 2.01 of the Zend Engine license, which updates the legal entity owning the license. - Reference a URL to the 2.01 version of the license - Provide the 2.01 version of the license in the LICENSE file (See php#7166 for the discussion that prompted this patch.)
Given that the Zend LICENSE file is still provided, removing those lines still respect the license.
Context: https://news-web.php.net/php.internals/114832