FPM fix and test for setting php_admin_value doc_root #7673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing the cPanel usage of PHP-FPM, we stumbled on this bug. Without the fix, the zend_string is corrupted and getting odd filenames When using FPM we kept getting "No input file specified". I work for cPanel and we use PHP extensively.
nikic
approved these changes
Nov 21, 2021
| * @param string|null $successMessage | ||
| * @param string|null $errorMessage | ||
| * @param bool $connKeepAlive | ||
| * @param string|null $scritpFilename |
There was a problem hiding this comment.
Suggested change
| * @param string|null $scritpFilename | |
| * @param string|null $scriptFilename |
...and below.
|
Merged this myself so it makes it into 8.1.0. |
|
Thanx all for tending to this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for #7660 fix and in that way also adds a coverage for the
doc_rootINI usage with FPM.The test has been verified and failing without a fix.