"Export" relevant GD macros #7680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For parity with non Windows systems, we should `AC_DEFINE` these macros so that they are defined in config.w32.h instead of directly passed to the compiler. This allows extensions which have ext/gd as dependency to check for these macros. E.g. ext/ps does this[1], and fails to build on Windows, because `HAVE_GD_BUNDLED` isn't defined. [1] <https://github.com/steinm/ps/blob/RELEASE_1_4_4/ps.c#L34>
nikic
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parity with non Windows systems, we should
AC_DEFINEthese macrosso that they are defined in config.w32.h instead of directly passed to
the compiler. This allows extensions which have ext/gd as dependency
to check for these macros. E.g. ext/ps does this[1], and fails to
build on Windows, because
HAVE_GD_BUNDLEDisn't defined.[1] https://github.com/steinm/ps/blob/RELEASE_1_4_4/ps.c#L34
Note that I targeted PHP-8.0 which is a compromise. Fixing this for PHP-7.4 might make sense as well, although ext/pd can't be build for that version with GD support anyway (https://bugs.php.net/81639).