Skip to content

Improve final/abstract methods in interfaces error messages #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

iluuu1994
Copy link
Member

Closes #81683

@iluuu1994 iluuu1994 changed the base branch from master to PHP-8.1 December 5, 2021 19:28
@iluuu1994
Copy link
Member Author

Not sure if this should fixed in master, PHP-8.0 or PHP-8.1.

@nikic
Copy link
Member

nikic commented Dec 5, 2021

PHP-8.1 sounds right.

@TysonAndre
Copy link
Contributor

========DIFF========
001+ Fatal error: Interface method test::test() must not be final in C:\projects\php-src\Zend\tests\bug71871.php on line 4
001- Fatal error: Access type for interface method test::test() must be public in %s on line %d
========DONE========
FAIL Bug #71871: Interfaces allow final and abstract functions [C:\projects\php-src\Zend\tests\bug71871.phpt] 
PASS bug #71428.1: inheritance with null default values [C:\projects\php-src\Zend\tests\bug71428.1.phpt] 
                                                     
========DIFF========
001+ Fatal error: Interface method test::test() must not be abstract in C:\projects\php-src\Zend\tests\bug71871_2.php on line 4
001- Fatal error: Access type for interface method test::test() must be public in %s on line %d
========DONE========
FAIL Bug #71871: Interfaces allow final and abstract functions [C:\projects\php-src\Zend\tests\bug71871_2.phpt]

We already have some tests that (1) need to be updated and (2) may make new tests redundant. lgtm otherwise

iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Dec 5, 2021
@iluuu1994 iluuu1994 merged commit b991ce9 into php:PHP-8.1 Dec 5, 2021
@iluuu1994 iluuu1994 deleted the bug81683 branch December 5, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants