Skip to content

Fix the $value param of SimpleXMLElement::addAttribute() #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix the $value param of SimpleXMLElement::addAttribute() #7811

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Dec 22, 2021 •
edited
Loading

It looks like the change from #7033 was accidentally reverted when I added the tentative return types around the same time.

cmb69
cmb69 approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, indeed!

@kocsismate kocsismate deleted the fix-simplexml-add-attribute branch December 22, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @cmb69