Skip to content

Remove bogus type of $object param in SplObjectStorage::offsetSet() #7840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove bogus type of $object param in SplObjectStorage::offsetSet() #7840

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Dec 28, 2021 •
edited
Loading

The parameter definitely only accepts objects, so we shouldn't explicitly mark it as mixed. Looks like I (accidentally (?)) added this type in https://github.com/php/php-src/pull/7235/files#diff-01509803e11a18aa23ee35cf1243406221d39a275722504d435a33b08add0fa1R93

This will fix the generated method synopsis of SplObjectStorage::offsetSet().

cmb69
cmb69 approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kocsismate kocsismate deleted the spl-offset-set branch December 28, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @cmb69