-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Close stale PRs with GitHub actions #7999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you! I'm generally fine with automatically closing inactive PRs, and the implementation seems to be okay. Maybe we should also echo the
I don't think this is a big problem. At least after a while, it's unlikely that we'll have more than 30 PRs to close per day.
Yeah, that looks reasonable. |
Yes, https://github.com/iluuu1994/stale-prs/runs/4941250141?check_suite_focus=true |
I think this includes |
141a517
to
7f5832c
Compare
I've adjust the configuration according to the feedback. Let me know if you're ok with this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
Thanks! I'll check the output of the action in the coming days and disable |
As discussed in r11. Open question:
operations-per-run is currently configured to
30
.I'm not sure if we're subject to rate limiting. Leaving it as is would probably mean that stale PRs would only get closed over time instead of at once.
debug-only
is enabled since I'm not sure if GitHub will run actions that are not merged yet. We might even leave it enabled after merging for a few days to see if it behaves correctly.