Fix -Werror=sign-compare warning in zend_memnistr when compiling with -Werror
#8042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`error: comparison of integer expressions of different signedness: ‘size_t’ {aka
‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]`
This is asserting `end >= haystack` as a precondition for callers (in debug
builds) and existing callers are correct.
An alternate option is to cast the left side to `int64_t`, but that may be
slightly inefficient for 32-bit builds.
iluuu1994
approved these changes
Feb 5, 2022
My original PR summary/title was wrong - this was using |
|
@TysonAndre Ah I see. I thought I missed the error in the large compilation output (happened before). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]This is asserting
end >= haystackas a precondition for callers (in debugbuilds) and existing callers are correct.
An alternate option is to cast the left side to
int64_t, but that may beslightly inefficient for 32-bit builds (to account for >=2GB strings).
Noticed when locally developing with
-Werror