Skip to content

Haiku fix ZTS build, disabling tls model #8047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Haiku fix ZTS build, disabling tls model #8047

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Feb 6, 2022

No description provided.

cmb69
cmb69 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't know about Haiku, but you certainly do, so this looks good to me. :)

@cmb69 cmb69 closed this in bea542a Feb 7, 2022
@mvorisek
Copy link
Contributor

mvorisek commented Mar 7, 2022 •
edited
Loading

@devnexen can you see opcache ext as loaded /w JIT enabled with this, to me incomplete, fix on Haiku?

see related issue #8180 (comment) discussion

@devnexen
Copy link
Member Author

devnexen commented Mar 7, 2022

afaik it is irrelevant in case of haiku as opcache does not work at all in the first place in this platform.

@mvorisek
Copy link
Contributor

mvorisek commented Mar 7, 2022

afaik it is irrelevant in case of haiku as opcache does not work at all in the first place in this platform.

thanks for the reply, still, shouln't Haiku be checked here too

php-src/TSRM/TSRM.c

Line 739 in abd9529

#elif defined(__x86_64__) && defined(__GNUC__) && !defined(__FreeBSD__) && !defined(__OpenBSD__) && !defined(__MUSL__)
?

@devnexen
Copy link
Member Author

devnexen commented Mar 7, 2022

sure why not, haiku is still in beta and does not support yet tls model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @mvorisek @cmb69