Skip to content

Adjusted PHP_SETUP_LIBXML description to mention what it doesnt use action-not-found #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2022
Merged

Adjusted PHP_SETUP_LIBXML description to mention what it doesnt use action-not-found #8088

merged 1 commit into from
Mar 8, 2022

Conversation

vityank
Copy link
Contributor

@vityank vityank commented Feb 12, 2022

No description provided.

cmb69
cmb69 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm not quite sure whether we should fix the comment, or whether we should fix the behavior broken by commit cc930cd. Since apparently nobody complained so far, just fixing the comment seems to be the way to go.

@cmb69 cmb69 merged commit 6a2c501 into php:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vityank @cmb69