Allowing catching arg type deprecations in intl classes #8117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Feb 18, 2022
Girgias
reviewed
Feb 18, 2022
|
Other than RuleBreakerIterator which I don't think needs the error handler to be replaced, the other ones are a bit more complicated than I anticipated as Intl's internal error mechanism is very whack. Might make more sense to merge this and refactor for master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-8115
Doesn't affect PHP-8.0 since the "Passing null to parameter" deprecation was introduced in PHP 8.1.
It's somewhat sub-optimal that
zend_replace_error_handlingandzend_restore_error_handlingare now called in different places but moving them into the given function was not trivially possible because the inner functions usually have multiple exit points.