ext/opcache: merge redundant code and "bool" refactoring #8237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKellermann
force-pushed
the
opcache-redundant-code
branch
from
e2d68c1 to
f63094e
Compare
iluuu1994
reviewed
Mar 24, 2022
Simplify the #iddef ZEND_WIN32.
Eliminates lots of redundant casts and avoids reloading the variable from RAM into registers.
This eliminates duplicate error handling code.
MaxKellermann
force-pushed
the
opcache-redundant-code
branch
from
f63094e to
a0d8d0b
Compare
iluuu1994
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things; if you prefer to merge the "bool" refactoring first, I can split the PR; the second part which merges redundant code depends on the "bool" patches.