Query *always executes twice* when calling SQLite3Result.fetcharray() #8386
Conversation
In SQLite3.query() and SQLite3Stmt.execute(), if success and SQLITE_ROW is true or SQLITE_DONE is true, *do not reset the statement*, otherwise when you execute SQLite3Result.fetcharray() the sqlite 'step' instruction executes the query again. Imagine an expensive query being executed *two times*... Please, please patch this. Thank you! :-)
There was a problem hiding this comment.
This simple approach causes a lot of test failures. Note that this bug is known for years, but appears hard, if not impossible to solve without seriously breaking BC.
|
Hi, It's not impossible to solve, and IMHO, nor hard. I have a version of the code with a few more changes that the ones I first proposed, that solves the bug in a simple way (just addeded an int and four lines of code). I'm using it right now on my php build with no compilation or execution issues. No more double execution of queries when using SQLite3Result->fetcharray() afer a call to SQlite3->query() or SQLite3Stmt->execute(). What should I do to have those changes reviewed? I'm new to github. Thank you! :-) |
|
Just push the changes to your branch HochMartinez:patch-1. Then CI should be triggered again. |
|
Hi Christoph, I just pushed the new fix here: It affects two files, Sqlite3.c and php_sqlite3_structs.h. As I commented, the patch does not affect the error logic. It's a very simple fix, so all should work fine. Thanks and greetings from Barcelona... :-) |
|
Thank you! So I'm closing this PR in favor of #8415. |
In SQLite3.query() and SQLite3Stmt.execute(), if success and SQLITE_ROW is true or SQLITE_DONE is true, do not reset the statement, otherwise when you execute SQLite3Result.fetcharray() the sqlite 'step' instruction executes the query again. Imagine an expensive query being executed two times... Please, please patch this. Thank you and keep up the good work! :-)