Skip to content

Refactor CLI SAPI php_cli_server_client struct to use zend_string #8522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 15, 2022
Merged

Refactor CLI SAPI php_cli_server_client struct to use zend_string #8522

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
5692fa2
Convert php_cli_server_client->addr_str to zend_string
Girgias May 9, 2022
e770e27
Convert php_cli_server_client->current_header_name to zend_string
Girgias May 9, 2022
bb2b624
Convert php_cli_server_client->current_header_value to zend_string
Girgias May 9, 2022
14c592e
Add some assertions
Girgias May 10, 2022
ebf6581
Duplicate original name header
Girgias May 10, 2022
ab212be
Use bool instead of unsigned int with a size of 1 bit
Girgias May 11, 2022
438f032
Add break again (don't know why I removed that one)
Girgias May 12, 2022
a014824
Add an assertion about the reallocation
Girgias May 12, 2022
e5dea7e
Actually free persistent header value
Girgias May 12, 2022
782e0c9
Make request->headers store zend_string as IS_STRING zval instead as …
Girgias May 13, 2022
74b2375
Revert "Duplicate original name header"
Girgias May 13, 2022
fccca66
Revert "Revert "Duplicate original name header""
Girgias May 13, 2022
a2d0106
Do not duplicate add_str, just add a refcount
Girgias May 13, 2022
b0246d4
Revert "Do not duplicate add_str, just add a refcount"
Girgias May 13, 2022
fa21d10
Improve name + comment
Girgias May 13, 2022
cb78ce4
Server should not crash if request is interupted early
Girgias May 15, 2022
36f69ec
Make header name persistent
Girgias May 15, 2022
c381cea
Extract common code into a function
Girgias May 15, 2022
5e16552
Output Server errors
Girgias May 15, 2022
877007e
Spelling
Girgias May 15, 2022
866ffc6
Fix heap use after free
Girgias May 15, 2022
ba5d78b
Cleanup tests
Girgias May 15, 2022
0af9a5e
Fix Clang MSAN
Girgias May 15, 2022
cd7d695
Cater to Windows proc_terminate status code
Girgias May 15, 2022
1c821d8
bleh
Girgias May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading