Build ext/zip as shared library by default on Windows #8549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to use PECL/zip, which is well maintained and often brings new features which are not yet available in ext/zip, as drop-in replacement for the official Windows php-src builds.
|
Travis CI failure is unrelated. |
|
Yes, I think it make sense to build as much as possible extensions shared This give more flexibility to users: can remove unneeded ones (reduce memory usage) or update internal with pecl alternative. +1 (btw, can't review the .w32 change ;) but seems ok to me) |
|
If there are no objections, I'll merge this by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use PECL/zip, which is well maintained and often
brings new features which are not yet available in ext/zip, as drop-in
replacement for the official Windows php-src builds.
As it is now, building Windows binaries for PECL/zip is pretty much useless, since these builds can't used for the official php-src binaries, because these have ext/zip statically built-in.