Panic with abort() #8590
Merged
Panic with abort() #8590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain how run-tests gets more insights for |
|
Currently run-tests ignores the exit status, and only cares about the termination signal. So exit(1) here was ignored by run-tests. We should also change run-tests so that it doesn't ignore the exit status anymore. |
|
@morrisonlevi We have some tests which are testing error scenarios and thus returning error codes. We'd need to teach run-tests to have an expected status code then. (which may make sense, but is more work to do) |
nikic
approved these changes
May 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
zend_mm_panic()so thatabort()is used instead ofexit(1).The goal is to make panics more detectable by run-tests even when
zend_mm_panic()was not able to write to stderr (see #8588).An other effect is that
abort()will also skip normal process termination (e.g. atexit functions, flushing stdio streams). I think that this is desirable in case of memory corruption.