Update warning messages about undefined variables #8912
Conversation
|
It looks like one of the files was saved incorrectly, I'll dig into why, probably an editor issue. https://github.com/php/php-src/pull/8912/files#diff-a639e5dd9c3864e9767fadfc556a754d955da151cbc5d9a2902cb4122b4027f4 |
|
Shouldn't the tests be fixed not to have undefined variables, otherwise they will break in 9.0? |
That is a character encoding issue (file was ISO-Latin, now is UTF-8). |
That will need to be done, but it doesn't need to be done for 8.2 |
|
So far as I can see from scanning the codebase and tests, this should be ready to go to review. |
Zend/zend_execute.c
Outdated
| @@ -269,7 +269,7 @@ static zend_never_inline ZEND_COLD zval* zval_undefined_cv(uint32_t var EXECUTE_ | |||
| { | |||
| if (EXPECTED(EG(exception) == NULL)) { | |||
| zend_string *cv = CV_DEF_OF(EX_VAR_TO_NUM(var)); | |||
| zend_error(E_WARNING, "Undefined variable $%s", ZSTR_VAL(cv)); | |||
| zend_error(E_WARNING, "Undefined variable $%s (This will become an error in PHP 9.0)", ZSTR_VAL(cv)); | |||
There was a problem hiding this comment.
I don't think we should start a new sentence here (and for the other messages):
| zend_error(E_WARNING, "Undefined variable $%s (This will become an error in PHP 9.0)", ZSTR_VAL(cv)); | |
| zend_error(E_WARNING, "Undefined variable $%s (this will become an error in PHP 9.0)", ZSTR_VAL(cv)); |
@kocsismate, what do you think?
There was a problem hiding this comment.
Hm, yes, lowercasing looks slightly better to me :)
There was a problem hiding this comment.
I'll change this later this week.
markrandall
force-pushed
the
undefined-var-alerts
branch
from
de6ee5d to
039885e
Compare
…errors in PHP 9.0
The proper test expectation is a CR instead of a LF.
markrandall
force-pushed
the
undefined-var-alerts
branch
from
d9346b5 to
8858ca7
Compare
|
Now only sapi/fpm/tests/bug77106-fcgi-missing-nl.phpt is failing :) But otherwise the PR LGTM! |
markrandall
requested review from
iluuu1994,
bukka,
Girgias and
devnexen
as code owners
|
@markrandall this requires a rebase :) |
As per RFC https://wiki.php.net/rfc/undefined_variable_error_promotion the next version will include a modified warning message when accessing undefined variables to indicate that they will become errors in PHP 9.0.