Check at compile time that a built-in class is not being aliased #9402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one tries to use such an alias as a type declaration the following error would be raised: Fatal error: Cannot use 'int' as class name as it is reserved
iluuu1994
approved these changes
Aug 23, 2022
| echo $e::class, ': ', $e->getMessage(), PHP_EOL; | ||
| } | ||
| try { | ||
| eval("use $type as A; function foo$type(A \$v): A { return \$v; }"); |
There was a problem hiding this comment.
Kind of useless as all the above tests already Compile or ParseError.
There was a problem hiding this comment.
I added this because if I didn't add the early return in the C code when the use statement is created, it would create a non catchable fatal error.
But yes it is redundant :)
cmb69
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Well, the error message may be helpful, so it's an improvement. I wonder whether we should match the wording with https://3v4l.org/bl5dY; I do like "special class name" somehow, but there is ReflectionNamedType::isBuiltin(), so "built-in type" might be preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one tries to use such an alias as a type declaration the following error would be raised:
Fatal error: Cannot use 'int' as class name as it is reserved