No longer allow block mode for declare(encoding) #9455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in php#9446, this isn't properly supported, and it is doubtful if it ever can be useful, let alone if it could be properly supported. Therefore, we disallow the confusing block mode in the first place.
bwoebi
reviewed
Sep 1, 2022
Comment on lines
+16
to
+17
| --EXPECTF-- | ||
| Fatal error: Encoding declaration pragma must not use block mode in %s on line %d |
There was a problem hiding this comment.
Makes no sense to test block mode thrice. Just change the test to not use block mode (or drop it if redundant).
There was a problem hiding this comment.
Yeah, right! This was just to get CI green quickly. I'll update/fix this soonish.
Girgias
reviewed
Sep 1, 2022
| @@ -6109,6 +6109,11 @@ static void zend_compile_declare(zend_ast *ast) /* {{{ */ | |||
| zend_error_noreturn(E_COMPILE_ERROR, "Encoding declaration pragma must be " | |||
| "the very first statement in the script"); | |||
| } | |||
|
|
|||
| if (ast->child[1] != NULL) { | |||
| zend_error_noreturn(E_COMPILE_ERROR, "Encoding declaration pragma must not " | |||
There was a problem hiding this comment.
Suggested change
| zend_error_noreturn(E_COMPILE_ERROR, "Encoding declaration pragma must not " | |
| zend_error_noreturn(E_COMPILE_ERROR, "Encoding declaration must not " |
I know that pragma is used in the current wording, but the strict_type one does not use this word, so it might make sense to change the wording to be consistent
|
No objections from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9446, this isn't properly supported, and it is
doubtful if it ever can be useful, let alone if it could be properly
supported. Therefore, we disallow the confusing block mode in the
first place.