Declare main constants in stubs - part 1 #9616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
const-main1
branch
2 times, most recently
from
a768398 to
f46ecad
Compare
cmb69
reviewed
Sep 27, 2022
There was a problem hiding this comment.
Thank you! This looks good to me, but I'm not sure that we should make these changes for PHP-8.2, given that we're already in the RC phase. Is there any particular good reason to still do this for PHP-8.2?
@ramsey, @adoy, @saundefined, thoughts?
OK, I admit that you are right, we don't have a very strong argument for including these changes for PHP 8.2, so I'll target master instead. |
kocsismate
force-pushed
the
const-main1
branch
from
f46ecad to
badc083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.