SO_ATTACH_REUSEPORT_CBPF filter update. #9690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the old code of this switch statement mixes spaces and tabs; could you please fix that right away? |
devnexen
force-pushed
the
reuseport_cbpf_upd
branch
from
6260676 to
51664a8
Compare
|
Thank you! Can you please indent the body of the switch statement by one additional level, as is customary for php-src and especially sockets.c? Other than that, I suppose this is good (unless there is a chance that |
devnexen
force-pushed
the
reuseport_cbpf_upd
branch
from
51664a8 to
9422758
Compare
bukka
reviewed
Oct 11, 2022
ext/sockets/sockets.c
Outdated
Comment on lines
1987
to
1988
| break; | ||
| default: |
There was a problem hiding this comment.
this still doesn't look like correct indent...
SDK_AD_QUEUE support to attach to a queue.
devnexen
force-pushed
the
reuseport_cbpf_upd
branch
from
9422758 to
a2f99af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK_AD_QUEUE support to attach to a queue.