Skip to content

Fix GH-9769: Improve error message for array unpacking in constant expression #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Zend/tests/array_unpack/gh9769.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
Unpacking arrays in constant expression
--FILE--
<?php

const A = [...[1, 2, 3]];
const B = [...['a'=>1, 'b'=>2, 'c'=>3]];
const C = [...new ArrayObject()];

?>
--EXPECTF--
Fatal error: Uncaught Error: Only arrays can be unpacked in constant expression in %sgh9769.php:5
Stack trace:
#0 {main}
thrown in %sgh9769.php on line 5
3 changes: 1 addition & 2 deletions Zend/zend_ast.c
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,7 @@ static zend_result zend_ast_add_unpacked_element(zval *result, zval *expr) {
return SUCCESS;
}

/* Objects or references cannot occur in a constant expression. */
zend_throw_error(NULL, "Only arrays and Traversables can be unpacked");
zend_throw_error(NULL, "Only arrays can be unpacked in constant expression");
return FAILURE;
}

Expand Down