opcache fixing w/x pages creation on freebsd 13.1 and above. #9896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the system allows these but admin can disable them system wide. However the procctl api permits to control it per process.
devnexen
force-pushed
the
fbsd13_opcache_wx_fix
branch
from
baa284e to
06daf0d
Compare
cmb69
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Thank you! Looks generally fine, but I'm not sure whether we should treat this as bug fix (after all, it's configurable).
@ramsey, @saundefined, @krakjoe, what do you think about targeting PHP-8.1?
|
Yes understood I m fine just merging in master in case. |
|
Merging to master sounds best to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the system allows these but admin can disable them system wide. However the procctl api permits to control it per process.