Fix #76093: Format strings w/o loss of precision w/ FORMAT_TYPE_DECIMAL #9909
Conversation
Passing the argument to NumberFormat::format() as a number loses precision if the value can not be represented precisely as a double or long integer. The icu library provides a "decimal number" type that avoids the loss of prevision when the value is passed as a string. Add a new FORMAT_TYPE_DECIMAL to explicitly request the argument be converted to a string and then passed to icu that way.
This extends the argument types of NumberFormat::formatCurrency() to include string, in the same way the earlier patch extended NumberFormat::format() to allow a string. This allows formatting values which can't be represented precisely as a double or long integer, using the "decimal number" type of the icu library.
|
If we wanted to keep using |
|
It looks like this PR is outdated. We might miss it. Sorry. |
|
Rebased and pushed to the same branch. I don’t have permission to reopen this PR, it seems – would you like me to open a new one? Also, I have no idea what GitHub did there, I certainly didn’t do anything related to this PR three days ago… |
|
@lucaswerkmeister It was done automatically (probably by GitHub). Seems like all code owners got assigned the open PR's touching their code. It seems like I can't also re-open it (even though I should have all perms to do that) as it was force pushed when closed. Best if you could open a new PR. |
|
Alright, done at #12432. |
Resubmit of @cscott’s PR #7782. Rebased onto latest master (pretty sure the ship to make this target PHP 8.2 has sailed), resolving in particular a conflict with 163a278.
Applied @cmb69’s suggestion to check sizeof at compile time. Did not apply @cmb69’s suggestion to revert to
zend_parse_method_parameters(); if I understand correctly, the suggested replacement forEMPTY_SWITCH_DEFAULT_CASE()would only evaluate iftype == FORMAT_TYPE_DEFAULT, so with a non-default$type, an invalid value wouldn’t have its type checked.