Skip to content

Archive PHP 7.4 and 8.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Archive PHP 7.4 and 8.0 #3

merged 2 commits into from
Jul 8, 2024

Conversation

alcaeus
Copy link
Contributor

@alcaeus alcaeus commented Jul 8, 2024

Adding PHP 7.4 and 8.0 to the release list allows us to fetch these files directly from the archives without fetching releases.json beforehand. I also added some debug output that's helpful in case Invoke-WebRequest fails to download the file - it wasn't always obvious what download failed.

@cmb69
Copy link
Member

cmb69 commented Jul 8, 2024

Thank you!

I also added some debug output that's helpful in case Invoke-WebRequest fails to download the file - it wasn't always obvious what download failed.

I like that!

@cmb69 cmb69 merged commit 9cf03b8 into php:main Jul 8, 2024
@alcaeus alcaeus deleted the archive-old-php branch July 8, 2024 12:11
@alcaeus
Copy link
Contributor Author

alcaeus commented Jul 8, 2024

Thank you for the quick merge. Can you tag v0.9?

@cmb69
Copy link
Member

cmb69 commented Jul 8, 2024

Can you tag v0.9?

I think we should also add support for PHP 8.4, which is supposed to be built with VS17, so besides some code additions, the README needs an update and there should be some tests. I'll try to see to that later today.

@alcaeus
Copy link
Contributor Author

alcaeus commented Jul 8, 2024

Sounds good - I considered that for a moment but didn't know what VS version it needed and didn't find any files, so I skipped that part for now.

@cmb69
Copy link
Member

cmb69 commented Jul 10, 2024

Just to let you know, I didn't forget to tag 0.9, but are looking for some further clarifications, so this might take a couple of days.

@alcaeus
Copy link
Contributor Author

alcaeus commented Jul 11, 2024

Just to let you know, I didn't forget to tag 0.9, but are looking for some further clarifications, so this might take a couple of days.

No worries - the current solution has our builds running, so no rush from my side!

@cmb69
Copy link
Member

cmb69 commented Jul 25, 2024

Finally, https://github.com/php/setup-php-sdk/releases/tag/v0.9 is available. \o/

@alcaeus
Copy link
Contributor Author

alcaeus commented Jul 25, 2024

Thank you!

cmb69 added a commit that referenced this pull request Sep 30, 2024
Besides a slight improvement to the error message, we also fix the
outdated documentation in README.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants