Fix #233 inline defined const #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines in a method or function are allowed in php. However they are added to the global scope. As this library now processes the full method body to be able to add more information into the reflected code, this caused issues. As the defines are added to the global scope of the execution they are basically defined at a file level when a define was executed. This is the best we can get right now to reflect what the application would do at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines in a method or function are allowed in PHP. However, they are added
to the global scope. As this library now processes the full method body to be
able to add more information into the reflected code, this caused issues.
As the defines are added to the global scope of the execution they are basically
defined at a file-level when a define was executed. This is the best we can get right now to
reflect what the application would do at runtime.
Fixes #233