Remove unused psr/log dependency
#247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelogs summary: - nikic/php-parser updated from v4.13.2 to v4.14.0 minor See changes: nikic/PHP-Parser@v4.13.2...v4.14.0 Release notes: https://github.com/nikic/PHP-Parser/releases/tag/v4.14.0 - symfony/polyfill-ctype updated from v1.25.0 to v1.26.0 minor See changes: symfony/polyfill-ctype@v1.25.0...v1.26.0 Release notes: https://github.com/symfony/polyfill-ctype/releases/tag/v1.26.0
Changelogs summary: - psr/log removed (installed version was 1.1.4)
|
Looks like you are correct, our ci is using composer-require-checker which checks for references in the code. This stage passes. So it is safe to remove this package. |
|
Thanks! Merged this |
This was referenced Jun 10, 2022
|
Is there a chance that you could create a new release with this change? There are a couple libraries/projects that can't update their |
|
This issue causes any library that uses this package to be incompatible with Symfony 6. Could we please have a release? |
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Oct 19, 2022
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Oct 19, 2022
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Oct 23, 2022
Up until v5.2, the library came bundled with `"psr/log": "^1.0"`, which prevented the usage of newer `psr/log` versions. See phpDocumentor/Reflection#247
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Nov 19, 2022
`phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Nov 29, 2022
`phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Dec 8, 2022
`phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247
jeromegamez
added a commit
to jeromegamez/google-cloud-php
that referenced
this pull request
Dec 14, 2022
`phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247
dwsupplee
pushed a commit
to googleapis/google-cloud-php
that referenced
this pull request
Dec 14, 2022
* fix: Allow `ServiceException` creation with `null` as the message Some tests explicitly set the message to `null` which breaks the creation of parent exceptions with newer PHP versions. Setting a default `$message = ''` does not prevent the problem, so we declare it with `null` being allowed, and check and replace it in the `ServiceException` constructor. The change is made in the `ServiceException` instead of the tests calling it incorrectly to reduce the scope of updated files in the context of the PR that handles the problem. * feat: Enable the usage of `"psr/log": "^2.0|^3.0"` `phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247 * feat: Enable the installation of Monolog V3 `psr/log` v1 included a TestLogger that was removed starting with v2. `fig/log-test` support all current versions of `psr/log`. * feat: Introduce V3 versions of AppEngine Formatters and Handlers * feat: Introduce LogMessageProcessors and their factory * add monolog 3 to root composer * remove provide * allow log-test 1.0 * remove log-test in favor of skipping tests * ignore cs warning Co-authored-by: Brent Shaffer <[email protected]>
bshaffer
added a commit
to googleapis/google-cloud-php-core
that referenced
this pull request
Jan 27, 2023
* fix: Allow `ServiceException` creation with `null` as the message Some tests explicitly set the message to `null` which breaks the creation of parent exceptions with newer PHP versions. Setting a default `$message = ''` does not prevent the problem, so we declare it with `null` being allowed, and check and replace it in the `ServiceException` constructor. The change is made in the `ServiceException` instead of the tests calling it incorrectly to reduce the scope of updated files in the context of the PR that handles the problem. * feat: Enable the usage of `"psr/log": "^2.0|^3.0"` `phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247 * feat: Enable the installation of Monolog V3 `psr/log` v1 included a TestLogger that was removed starting with v2. `fig/log-test` support all current versions of `psr/log`. * feat: Introduce V3 versions of AppEngine Formatters and Handlers * feat: Introduce LogMessageProcessors and their factory * add monolog 3 to root composer * remove provide * allow log-test 1.0 * remove log-test in favor of skipping tests * ignore cs warning Co-authored-by: Brent Shaffer <[email protected]>
bshaffer
added a commit
to googleapis/google-cloud-php-logging
that referenced
this pull request
Jan 27, 2023
* fix: Allow `ServiceException` creation with `null` as the message Some tests explicitly set the message to `null` which breaks the creation of parent exceptions with newer PHP versions. Setting a default `$message = ''` does not prevent the problem, so we declare it with `null` being allowed, and check and replace it in the `ServiceException` constructor. The change is made in the `ServiceException` instead of the tests calling it incorrectly to reduce the scope of updated files in the context of the PR that handles the problem. * feat: Enable the usage of `"psr/log": "^2.0|^3.0"` `phpdocumentor/reflection` started supporting `"psr/log": "^2.0|^3.0"` with v5.3. See phpDocumentor/Reflection#247 * feat: Enable the installation of Monolog V3 `psr/log` v1 included a TestLogger that was removed starting with v2. `fig/log-test` support all current versions of `psr/log`. * feat: Introduce V3 versions of AppEngine Formatters and Handlers * feat: Introduce LogMessageProcessors and their factory * add monolog 3 to root composer * remove provide * allow log-test 1.0 * remove log-test in favor of skipping tests * ignore cs warning Co-authored-by: Brent Shaffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋,
unless I'm mistaken,
psr/logis not used, but it is preventing other libraries/projects from using versions >1.xChangelogs summary:
nikic/php-parser updated from v4.13.2 to v4.14.0 minor
See changes: nikic/[email protected]
Release notes: https://github.com/nikic/PHP-Parser/releases/tag/v4.14.0
symfony/polyfill-ctype updated from v1.25.0 to v1.26.0 minor
See changes: symfony/[email protected]
Release notes: https://github.com/symfony/polyfill-ctype/releases/tag/v1.26.0
psr/log removed (installed version was 1.1.4)