Be strict about deprecations #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation was causing issues with deprecations triggered in the wrong conditions. By introducing controlled deprecations using doctrine/deprecation we are able to handle this more properly. The tests are updated to test the correct behavior, a new deprecation issue is created to track the deprecations.
jaapio
force-pushed
the
controlled/deprecations
branch
from
3497c5f to
b4d53cb
Compare
|
Thank you! |
|
Thanks you for your sponsorship! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation was causing issues with deprecations triggered in the wrong conditions. By introducing controlled deprecations using doctrine/deprecation we are able to handle this more properly.
The tests are updated to test the correct behavior, a new deprecation issue is created to track the deprecations.
fixes #178