Skip to content

Adds support for cursor based pagination #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rjacobso
Copy link
Contributor

@rjacobso rjacobso commented Nov 4, 2019

  • CurlResponse class gets passed back to ShopifyResource
  • ResponseHeaders are stored statically in ShopifyResource after each
    call
  • New functions to check headers for next/prev links and return proper
    data string

 - CurlResponse class gets passed back to ShopifyResource
 - ResponseHeaders are stored statically in ShopifyResource after each
call
 - New functions to check headers for next/prev links and return proper
data string
@tareqtms
Copy link
Contributor

tareqtms commented Dec 7, 2019

@rjacobso
The changes are not backward-compatible, so we cannot merge this now. (If we do, it may break many sites using the package.) We need to keep it for a new major release. May be version 2.0.0.

@pankajYIT
Copy link

please give update on pagination api

@asacarter
Copy link

asacarter commented Jan 21, 2020

I've just found this Shopify library but at the moment I can't use it because it does not support the new pagination.

In April, the previous API version will be deprecated and break existing code.

Is there any update to when this fix will be resolved? It doesn't matter if it breaks previous versions of the API as they will be deprecated soon anyway...

@rjacobso
Copy link
Contributor Author

rjacobso commented Feb 7, 2020

Just tried again with #136 which shouldn't break anything. Closing this one

@rjacobso rjacobso closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants