Skip to content

Make valgrind run on travis tests of v8js in php7 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make valgrind run on travis tests of v8js in php7 #248

wants to merge 1 commit into from

Conversation

TysonAndre
Copy link
Contributor

@TysonAndre TysonAndre commented Aug 1, 2016

Valgrind checks for invalid memory accesses and memory leaks.

"-m" makes php unit tests use valgrind (and malloc instead of emalloc, etc.)

See https://travis-ci.org/TysonAndre/v8js/jobs/149018507 - It takes 20 minutes. Also, tests of setting memory limits/time limits should be disabled if valgrind is detected in getenv('TEST_PHP_ARGS')

Also, the bugs I was trying to catch affects non-zts builds, and travis uses zts builds (see travis output below).

You are already using composer version 1.2.0 (stable channel).
$ php --version
PHP 7.0.9 (cli) (built: Jul 22 2016 14:41:38) ( ZTS )
Copyright (c) 1997-2016 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies
    with Zend OPcache v7.0.9, Copyright (c) 1999-2016, by Zend Technologies
    with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans

Valgrind checks for invalid memory accesses and memory leaks.

"-m" makes php unit tests use valgrind (and malloc instead of emalloc, etc.)
@TysonAndre TysonAndre changed the title Make valgrind run on travis tests of v8js Make valgrind run on travis tests of v8js in php7 Aug 1, 2016
@TysonAndre
Copy link
Contributor Author

Opened #249 instead.

@TysonAndre TysonAndre closed this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant