Don't use zend_string for registerExtension- It may be freed #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... before module shutdown
(In NTS builds of PHP 7 (e.g. 7.0.9) only)
Fixes #247
This no longer returns getExtensions() in the order in which they were
registered. vector<pair<char*, v8js_extension*>>> could be added to reproduce the old behavior if this was desirable.
This is slightly wasteful of memory - A custom hash function and
equality function for
const char*
is possible to add to this for an unordered_map