avoid ramda.omit for forwarding props #703
Description
As discussed in #695
Not for now, but just because I'm thinking about it: I'd like us to consider moving away from
omit
for forwarding props to 3rd-party components, and usepick
instead. IMOomit
makes it too hard to follow which props are being passed on, too easy to forget to remove newly added props, and makes us lazy about accepting someone else's choice of names and values even if they don't make sense in our case.
To which @Marc-Andre-Rivet responded:
@alexcjohnson Agreed for DCC! There's also a bit of this happening in the table fragments / d3-format wrappers that should be looked into. Due to its generated nature I'd say whether this makes sense on HTML components would have to be evaluated independently.
Agreed re: HTML.
Opening the issue here as DCC is the main culprit, but it may be worth looking at table and other repos as well to see if it applies.