Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Update requirements to support React 16 #165

Closed
wants to merge 19 commits into from
Closed
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,28 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.22.0] - 2018-02-24
### Changed
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`
- Add `style-loader` and `css-loader` to webpack babel loaders to support
new version of `react-dates` with separate css file
- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.21.1] - 2018-03-28
### Fixed
- In some cases, frequently multi-page apps, the `dcc.Graph` interactive properties
Expand Down Expand Up @@ -106,7 +128,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
9 changes: 8 additions & 1 deletion config/webpack/partials/babel.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{ test: /\.json$/, loader: 'json-loader' },
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand All @@ -19,8 +19,15 @@ module.exports = function (config) {
* and avoid webpack's magick loader resolution
*/
loader: require.resolve('babel-loader')
},
{
test: /\.css$/,
loaders: ['style-loader', 'css-loader']
}
]
},
alias: {
'react-dates/lib/css/_datepicker.css': path.join(ROOT, 'node_modules', 'react-dates/lib/css/_datepicker.css')
}
});
};
7 changes: 7 additions & 0 deletions config/webpack/partials/babelHot.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,15 @@ module.exports = function (config) {
require.resolve('react-hot-loader'),
require.resolve('babel-loader')
]
},
{
test: /\.css$/,
loaders: ['style-loader', 'css-loader']
}
]
},
alias: {
'react-dates/lib/css/_datepicker.css': path.join(ROOT, 'node_modules', 'react-dates/lib/css/_datepicker.css')
}
});
};
2 changes: 1 addition & 1 deletion dash_core_components/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.21.1'
__version__ = '0.22.0'
Loading