Set Graph id to be optional

[valentijnnieman]

This sets the Graph's id prop to not be required, and defines a defaultProp value for it set to 'untitled-graph' so Plotly.js still works.

[chriddyp]

Nice! I believe that we'll need the graph ID to be dynamic so that users can embed multiple graphs. There are a few places in the plot code that require unique IDs, like:

 Plotly.Plots.resize(document.getElementById(this.props.id));

and

PlotMethod(id, figure.data, figure.layout, config)

[valentijnnieman]

@chriddyp Yep, makes sense. So if the user defines more than one dcc.Graph without providing an id they will both have the defaultProp.id of 'untitled-graph'. Any suggestion of how to fix that? Create a random string?

[chriddyp]

Any suggestion of how to fix that? Create a random string?

Yeah, I think that's what we'll have to do

[bpostlethwaite]

Why is this getting nuked?

[valentijnnieman]

Looks like it was added here 0be4e4c

[valentijnnieman]

There's no Confirm component though - perhaps you triggered a build and had some uncommited code (like a src/components/Confirm.react.js file perhaps) and released the previous version, and now when I'm building, the data is getting nuked.

[T4rk1n]

It was called Confirm at first, but I renamed it to ConfirmDialog.

[valentijnnieman]

Yeah, so that's probably what happened.

[bpostlethwaite]

Looks good to me!

[chriddyp]

Looks good to me!

It's odd that the diff for the bundle was so huge, not sure why:

Could we also add a quick test that has two different graphs with different figures? No need to do any assertions, a screenshot would suffice

[valentijnnieman]

@chriddyp Do you want to take a look at the Percy screenshot?

[chriddyp]

@chriddyp Do you want to take a look at the Percy screenshot?

Woops, sorry I missed this. In the future, feel free to go in there and approve them yourselves :)

💃