This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Fix Tabs and Tabs tests #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriddyp
reviewed
Sep 18, 2018
test/test_integration.py
Outdated
| @@ -629,6 +638,11 @@ def render_content(tab): | |||
| self.snapshot("Tabs with Graph - initial (graph should not resize)") | |||
| tab_two.click() | |||
|
|
|||
| # wait for content to be loaded after clicking | |||
| WebDriverWait(self.driver, 10).until( | |||
| EC.visibility_of_element_located((By.ID, "tabs-content-example")) | |||
There was a problem hiding this comment.
should you be looking for data that's actually inside the tab rather than the tab container itself? We might even want to wait for the graph to be rendered. i.e. something like #graph--tabs .svg-container. Similarly below when you switch tabs (#graph-2-tabs .svg-container`)
valentijnnieman
force-pushed
the
hotfix-tabs
branch
from
7a44c81 to
9132aff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I made a mistake when merging in master in previous PR #279 , and the fix wasn't included (
clone(figure.layout)). I've put it back in, as well as removed the console.log, so this closes #300 too. Apologies, I won't merge & publish when I have a fever and should've been in bed anymore!