This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Update dashCoreComponents package in R to 0.44.0 #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkyle
changed the title
alexcjohnson
reviewed
Mar 8, 2019
package.json
Outdated
| "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && dash-generate-components ./src/components dash_core_components", | ||
| "build:r": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && dash-generate-components ./src/components dash_core_components --r-prefix 'core'", | ||
| "build:py": "dash-generate-components ./src/components dash_core_components", | ||
| "build:r": "dash-generate-components ./src/components dash_core_components --r-prefix 'dcc'", |
There was a problem hiding this comment.
Again, let's 🔪 extract-meta
alexcjohnson
reviewed
Mar 8, 2019
man/dccChecklist.Rd
Outdated
| @@ -10,7 +10,7 @@ Checklist is a component that encapsulates several checkboxes. The values and la | |||
| } | |||
|
|
|||
| \usage{ | |||
| coreChecklist(id=NULL, options=NULL, values=NULL, className=NULL, style=NULL, inputStyle=NULL, inputClassName=NULL, labelStyle=NULL, labelClassName=NULL, ...) | |||
| dccChecklist(id=NULL, options=NULL, values=NULL, className=NULL, style=NULL, inputStyle=NULL, inputClassName=NULL, labelStyle=NULL, labelClassName=NULL, loading_state=NULL, ...) | |||
There was a problem hiding this comment.
These ones still have ... at the end, but looks like the components themselves lost that a while back?
There was a problem hiding this comment.
Thanks again for noting this -- it turns out there were actually two separate issues to address.
This has been fixed in plotly/dash#638; when that PR is merged, ... will only appear when wildcards are supported by the component.
There was a problem hiding this comment.
The components being merged here were 'transpiled' using the updated code from the aforementioned PR ☝️, so the stray ellipsis has been 🔪.
alexcjohnson
approved these changes
Mar 8, 2019
rpkyle
added a commit
that referenced
this pull request
Mar 28, 2019
#482 renamed core* to dcc*, coreLoading.R is not even exported, so it can be safely deleted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to updating
dash_core_components.min.jsanddash_core_components.dev.jsto version 0.44.0, and includingplotly-1.45.0.min.js, this PR also aims to incorporate support for loading_state in "transpiled" dashR components.Some simplification of the component generation statements in
package.jsonis proposed as well.