Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Issue 691 - Update plotlyjs #693

Merged
merged 4 commits into from
Nov 4, 2019
Merged

Issue 691 - Update plotlyjs #693

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1a5d9d
update plotlyjs to 1.51.1
Nov 4, 2019
d2e9287
changelog
Nov 4, 2019
c4c254c
update test to not be subject to "month-ends-on-Saturday-bug"
Nov 4, 2019
7dd46e6
Update CHANGELOG.md
Marc-Andre-Rivet Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Updated
- [#693](https://github.com/plotly/dash-core-components/pull/693) Upgraded plotly.js to 1.51.1
- [Feature release 1.51.0](https://github.com/plotly/plotly.js/releases/tag/v1.51.0) which contains:
- Patch release [1.51.1](https://github.com/plotly/plotly.js/releases/tag/v1.51.1) containing several bug fixes.

## [1.4.0] - 2019-10-29
### Added
- [#616](https://github.com/plotly/dash-core-components/pull/616) Async Graph and Plotly.js
Expand Down
4 changes: 2 additions & 2 deletions dash_core_components_base/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@
'dynamic': True
},
{
'relative_package_path': 'plotly-1.50.1.min.js',
'relative_package_path': 'plotly-1.51.1.min.js',
'external_url': (
'https://unpkg.com/dash-core-components@{}'
'/dash_core_components/plotly-1.50.1.min.js'
'/dash_core_components/plotly-1.51.1.min.js'
).format(__version__),
'namespace': 'dash_core_components',
'async': 'eager'
Expand Down
79 changes: 39 additions & 40 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"color": "^3.1.0",
"fast-isnumeric": "^1.1.3",
"moment": "^2.20.1",
"plotly.js": "1.50.1",
"plotly.js": "1.51.1",
"prop-types": "^15.6.0",
"ramda": "^0.26.1",
"rc-slider": "^8.6.11",
Expand Down
4 changes: 1 addition & 3 deletions tests/integration/calendar/test_date_picker_single.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ def cb(clicks):
switch.click()

memorized = dash_dcc.select_date_single("dps-memory", day="4")
amnesiaed = dash_dcc.select_date_single(
"dps-none", day="1", outside_month=True
)
amnesiaed = dash_dcc.select_date_single("dps-none", day="11")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting month rollover bug in this test. November 2019 ends on a Saturday, there is no 1st day of next month in this calendar! This is the only instance where we are checking for "out-of-month" days in dcc tests. Out-of-month is not important here as we are really just testing persistence.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny enough, https://github.com/plotly/dash-core-components/pull/692/commits was not affected even with the last commit happening in November b/c the test does -timedelta(days=1)


switch.click()
assert dash_dcc.wait_for_text_to_equal("#out", "switched")
Expand Down