Add picking support #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
requested review from
alexcjohnson,
Marc-Andre-Rivet and
xhluca
as code owners
|
@xhlulu I'm not sure what is required next to bump the version and publish a new version? Can you take over that PR? Or let me know what I should do next. Thx |
|
@jourdain Yeah I can handle releases. In fact it's probably better if I set it up to be automated; will think about that later. I have a minor change to propose. Ok if I push directly to this branch? |
|
Yes go for it... |
added 2 commits
April 6, 2021 19:39
This ensures we are safe from mutations
added 2 commits
April 6, 2021 20:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Adding picking capabilities
Adding CubeAxes on GeometryRepresentation
Pre-Merge checklist
npm run build.