Skip to content

First pass at Windows CI testing. #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2020
Merged

First pass at Windows CI testing. #1127

merged 3 commits into from
Feb 27, 2020

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Feb 20, 2020 •
edited
Loading

About

Closes https://github.com/plotly/dash-core/issues/91

Needs plotly/dash-core-components#761 to be merged so that the --branch parameter can be removed from the line in which we clone dash-core-components.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follow
    • this github #PR number updates the dash docs
    • here is the show and tell thread in plotly dash community

@shammamah-zz shammamah-zz force-pushed the windows-circleci branch 11 times, most recently from 7f6d0fc to aee6f3e Compare February 25, 2020 20:26
@shammamah-zz shammamah-zz mentioned this pull request Feb 26, 2020
Merged
@shammamah-zz shammamah-zz mentioned this pull request Feb 26, 2020
Closed
@shammamah-zz shammamah-zz marked this pull request as ready for review February 26, 2020 22:01
@Marc-Andre-Rivet Marc-Andre-Rivet added this to the Dash v1.10 milestone Feb 27, 2020
Marc-Andre-Rivet
Marc-Andre-Rivet approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💃

@shammamah-zz shammamah-zz merged commit ba8abf6 into dev Feb 27, 2020
@shammamah-zz shammamah-zz deleted the windows-circleci branch February 27, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Andre-Rivet Marc-Andre-Rivet Marc-Andre-Rivet approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dash v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@shammamah-zz @Marc-Andre-Rivet