Speed up function _operation
by 80%
#3304
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 80% (0.80x) speedup for
_operation
indash/_patch.py
⏱️ Runtime :
477 microseconds
→264 microseconds
(best of393
runs)📝 Explanation and details
The largest bottleneck identified is from the unnecessary use of
dict(**kwargs)
, which creates a new dictionary from kwargs, but sincekwargs
is already a dictionary, this is just a redundant and potentially slower operation. You can usekwargs
directly, which saves both CPU and memory.Explanation:
kwargs
as is avoids an unnecessary dictionary copy, achieving lower runtime and memory usage."params"
entry will be the dictionary of arguments supplied via**kwargs
.This is the fastest and leanest way to implement your functionality per the profiling results.
✅ Correctness verification report:
🌀 Generated Regression Tests Details