Update circle 2 #338
Merged
Update circle 2 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try fix py37 pylint compat. Try fix py37 pylint compat. Ignore the renamed/new pylint rules.
Remove tox.ini
chriddyp
reviewed
Aug 16, 2018
| PYLINTRC: .pylintrc | ||
|
|
||
| "python-3.7": | ||
| <<: *test-template |
There was a problem hiding this comment.
nice work getting this test-template stuff in. code is super DRY 🐫
|
Looks great @T4rk1n ! There might be some CONTRIBUTING.md files or something that need updating as well. Otherwise, 💃 |
|
@chriddyp There is no CONTRIBUTING.md for dash, maybe we should add one ? |
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
AnnMarieW
pushed a commit
to AnnMarieW/dash
that referenced
this pull request
Jan 6, 2022
Change `React.PropTypes` to just `PropTypes` in `Tabs.children`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's mostly the same as #222 but with python 3.7 tests. Pylint for python 3.7 has changed some rules naming so I created another .pylintrc for that one.