Skip to content

add info on webgl context lost event #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

michaelbabyn
Copy link
Contributor

@michaelbabyn michaelbabyn commented Oct 5, 2018

resolves #1085 cc @etpinard

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Oct 5, 2018
@michaelbabyn michaelbabyn requested a review from cldougl October 5, 2018 18:31
cldougl
cldougl approved these changes Oct 10, 2018
@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 10, 2018
sitemap: false
arrangement: horizontal
markdown_content: |
Plotly graphs which use webgl receive a "webgl context" from the browser which gives them access to gpu resources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelbabyn -- sorry one quick suggestion usually webgl is capitalized as: WebGL
can you update the text w/ that (but the handler can remain as is: plotly_webglcontextlost :) )

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGL capitalization

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@michaelbabyn michaelbabyn merged commit 9edffd9 into source-design-merge Oct 11, 2018
@michaelbabyn michaelbabyn deleted the webglcontextlost-event branch October 11, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info about plotly_webglcontextlost event
2 participants